Lazy Context Propagation & useContextSelector hook #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoff
force-pushed
the
context-selectors
branch
2 times, most recently
from
0be9bfa
to
c8343ac
Compare
gnoff
commented
Jun 14, 2019
| @@ -1049,6 +1049,142 @@ describe('ReactNewContext', () => { | |||
| span(2), | |||
| ]); | |||
| }); | |||
| describe('stress test', () => { | |||
There was a problem hiding this comment.
not suggesting we keep this kind of test in place, but wanted to explore implications of this change in a more demanding environment than most tests produce
| expect(Scheduler).toFlushAndYield(['A: 4', 'B: 4', 'C: 4']); | ||
| } | ||
| }); | ||
| it('non-context stress test', () => { |
There was a problem hiding this comment.
this tests doesn't use context but acts as a comparable of non-context rendering to see if lazy context adds overhead to work in general
| @@ -186,6 +253,198 @@ function scheduleWorkOnParentPath( | |||
| } | |||
| } | |||
|
|
|||
| export function checkContextDependencies( | |||
There was a problem hiding this comment.
much of the new code in this file could be 'unified' with the existing propagation function to save on LoC but it would make the actual algorithm a little harder to see so it is duplicated
This was referenced Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will end up breaking into separate RFCs and PRs
For now
Lazy Propagation Algorithm: attempts to take advantage of already scheduled work to avoid walking the fiber tree except when necessary (on bailouts that don't go deeper for work on children)
useContextSelector hook: adds a hook that is a modified context reader. it will only schedule work on it's host fiber when the selector value has changed. This hook is intended to be used with the new propagation scheme because it otherwise has numerous problems with selectors running too often / too early.